linux-kernel - Re: [PATCH] cgroup: add cgroup.stat interface with basic hierarchy stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da7c5db5-355b-28aa-dbf8-9a0b6eb6c66e@redhat.com>
Date:   Thu, 27 Jul 2017 13:55:57 -0400
From:   Waiman Long <longman@...hat.com>
To:     Roman Gushchin <guro@...com>
Cc:     cgroups@...r.kernel.org, Tejun Heo <tj@...nel.org>,
        Zefan Li <lizefan@...wei.com>,
        Johannes Weiner <hannes@...xchg.org>, kernel-team@...com,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cgroup: add cgroup.stat interface with basic hierarchy
 stats

On 07/27/2017 01:46 PM, Roman Gushchin wrote:
> On Thu, Jul 27, 2017 at 01:38:55PM -0400, Waiman Long wrote:
>> On 07/27/2017 12:14 PM, Roman Gushchin wrote:
>>> Add a cgroup.stat interface to the base cgroup control files
>>> with the following metrics:
>>>
>>> nr_descendants		total number of descendant cgroups
>>> nr_dying_descendants	total number of dying descendant cgroups
>>> max_descendant_depth	maximum descent depth below the current cgroup
>> Both nr_descendants and max_descendant_depth can be found easily from
>> userspace by scanning the cgroup directory. nr_dying_descendants is a
>> transient figure and it should be 0 most of the time. So I wonder how
>> useful it can be.
>>
>> This new interface file will be more useful if it can reveal information
>> that cannot be easily obtained by looking from userspace alone.
> A cgroup can be in dying state for substantional amount of time
> (imagine a memcg which holds a page mlocked by a process in an other cgroup).
>
> The total amount of cgroups, as well as tree depth include dying cgroups,
> which are not visible from the userspace.
>
> The main purpose of this interface is to have a reasonable way to check if
> there are no leaks/refcounting issues, which prevents cgroups from being
> completely freed.
>

If that is the use case, I am OK with that. However, you may want to
document that either in the commit log or in the comment. Maybe you can
also list the full path of the offlined cgroups if it is what you are
looking for.

Cheers,
Longman