linux-kernel - Re: [PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <a7215815-66f9-6344-4b8c-c9f0bff4099d@linux.vnet.ibm.com>
Date:   Thu, 27 Jul 2017 14:12:52 -0500
From:   Michael Bringmann <mwb@...ux.vnet.ibm.com>
To:     Nathan Fontenot <nfont@...ux.vnet.ibm.com>,
        Tejun Heo <tj@...nel.org>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask


>>
>>  	/* yeap, return possible CPUs in @node that @attrs wants */
>>  	cpumask_and(cpumask, attrs->cpumask, wq_numa_possible_cpumask[node]);
>> +
>> +	if (cpumask_empty(cpumask)) {
>> +		pr_warn_once("WARNING: workqueue cpumask: onl intersect > "
>                                                           ^^^
> This message doesn't seem right, or I am missing something, "onl"?

Shorthand for 'online' in long message.

> 
> -Nathan
> 
>> +				"possible intersect\n");
>> +		return false;
>> +	}
>> +
>>  	return !cpumask_equal(cpumask, attrs->cpumask);
>>
>>  use_dfl:
>>
> 

-- 
Michael W. Bringmann
Linux Technology Center
IBM Corporation
Tie-Line  363-5196
External: (512) 286-5196
Cell:       (512) 466-0650
mwb@...ux.vnet.ibm.com