linux-kernel - Re: [PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170727192427.GJ742618@devbig577.frc2.facebook.com>
Date:   Thu, 27 Jul 2017 15:24:27 -0400
From:   Tejun Heo <tj@...nel.org>
To:     Michael Bringmann <mwb@...ux.vnet.ibm.com>
Cc:     Nathan Fontenot <nfont@...ux.vnet.ibm.com>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask

On Thu, Jul 27, 2017 at 02:12:52PM -0500, Michael Bringmann wrote:
> 
> >>
> >>  	/* yeap, return possible CPUs in @node that @attrs wants */
> >>  	cpumask_and(cpumask, attrs->cpumask, wq_numa_possible_cpumask[node]);
> >> +
> >> +	if (cpumask_empty(cpumask)) {
> >> +		pr_warn_once("WARNING: workqueue cpumask: onl intersect > "
> >                                                           ^^^
> > This message doesn't seem right, or I am missing something, "onl"?
> 
> Shorthand for 'online' in long message.

Let's please spell it out.

Thanks.

-- 
tejun