linux-kernel - Re: [PATCH] mtd: dataflash: Use ULL suffix for 64-bit constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Jul 2017 17:34:34 -0700
From:   Andrey Smirnov <andrew.smirnov@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        linux-mtd@...ts.infradead.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: dataflash: Use ULL suffix for 64-bit constants

On Sat, Jul 15, 2017 at 12:59 AM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> With gcc 4.1.2:
>
>     drivers/mtd/devices/mtd_dataflash.c:740: warning: integer constant is too large for ‘long’ type
>     drivers/mtd/devices/mtd_dataflash.c:741: warning: integer constant is too large for ‘long’ type
>
> Add the missing "ULL" suffix to fix this.
>
> Fixes: 67e4145ebf2c161d ("mtd: dataflash: Add flash_info for AT45DB641E")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

My bad, sorry about that. FWIW,

Acked-by: Andrey Smirnov <andrew.smirnov@...il.com>

> ---
>  drivers/mtd/devices/mtd_dataflash.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c
> index 5dc8bd042cc54b2d..504e34f295180fd9 100644
> --- a/drivers/mtd/devices/mtd_dataflash.c
> +++ b/drivers/mtd/devices/mtd_dataflash.c
> @@ -737,8 +737,8 @@ static struct flash_info dataflash_data[] = {
>         { "AT45DB642x",  0x1f2800, 8192, 1056, 11, SUP_POW2PS},
>         { "at45db642d",  0x1f2800, 8192, 1024, 10, SUP_POW2PS | IS_POW2PS},
>
> -       { "AT45DB641E",  0x1f28000100, 32768, 264, 9, SUP_EXTID | SUP_POW2PS},
> -       { "at45db641e",  0x1f28000100, 32768, 256, 8, SUP_EXTID | SUP_POW2PS | IS_POW2PS},
> +       { "AT45DB641E",  0x1f28000100ULL, 32768, 264, 9, SUP_EXTID | SUP_POW2PS},
> +       { "at45db641e",  0x1f28000100ULL, 32768, 256, 8, SUP_EXTID | SUP_POW2PS | IS_POW2PS},
>  };
>
>  static struct flash_info *jedec_lookup(struct spi_device *spi,
> --
> 2.7.4
>