linux-kernel - Re: [PATCH 2/2] arm64: dts: Add device node for pmi8994 gpios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0ad95d2-f79e-c3d4-1ac6-48d5d6e21956@codeaurora.org>
Date:   Thu, 27 Jul 2017 14:00:15 -0700
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     Vivek Gautam <vivek.gautam@...eaurora.org>,
        bjorn.andersson@...aro.org, linus.walleij@...aro.org,
        robh+dt@...nel.org, andy.gross@...aro.org,
        linux-arm-msm@...r.kernel.org
Cc:     rnayak@...eaurora.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: Add device node for pmi8994 gpios

On 07/26/2017 11:30 PM, Vivek Gautam wrote:
> Signed-off-by: Vivek Gautam <vivek.gautam@...eaurora.org>
> ---
>  arch/arm64/boot/dts/qcom/pmi8994.dtsi | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
> index d3879a4e8076..3b04ca63c31e 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
> @@ -8,6 +8,23 @@
>  		reg = <0x2 SPMI_USID>;
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> +
> +		pmi8994_gpios: gpios@...0 {
> +			compatible = "qcom,pmi8994-gpio";


Please also include the generic "qcom,spmi-gpio" compatible. We really
don't need to add the "qcom,pmi8994-gpio" one to the driver right now so
I would leave that out of the driver but leave it here in the dtsi file
of course.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project