linux-kernel - Re: [PATCH v3 1/3] ptp: introduce ptp auxiliary worker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74a827c9-467e-8791-3c97-9fc4c591435f@ti.com>
Date:   Thu, 27 Jul 2017 17:36:51 -0500
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     Richard Cochran <richardcochran@...il.com>
CC:     "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
        Sekhar Nori <nsekhar@...com>, <linux-kernel@...r.kernel.org>,
        <linux-omap@...r.kernel.org>, Wingman Kwok <w-kwok2@...com>,
        Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>,
        John Stultz <john.stultz@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v3 1/3] ptp: introduce ptp auxiliary worker



On 07/27/2017 03:08 PM, Richard Cochran wrote:
> On Wed, Jul 26, 2017 at 05:11:36PM -0500, Grygorii Strashko wrote:
>> @@ -217,6 +231,19 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
>>   	mutex_init(&ptp->pincfg_mux);
>>   	init_waitqueue_head(&ptp->tsev_wq);
>>   
>> +	if (ptp->info->do_aux_work) {
>> +		char *worker_name = kasprintf(GFP_KERNEL, "ptp%d", ptp->index);
> 
> This string is allocated but never freed.
> 
>> +		kthread_init_delayed_work(&ptp->aux_work, ptp_aux_kworker);
>> +		ptp->kworker = kthread_create_worker(0, worker_name ?
>> +						     worker_name : info->name);

Ops. Right need to add kfree(worker_name) here.


>> +		if (IS_ERR(ptp->kworker)) {
>> +			err = PTR_ERR(ptp->kworker);
>> +			pr_err("failed to create ptp aux_worker %d\n", err);
>> +			goto kworker_err;
>> +		}
>> +	}
>> +
> 
> Thanks,
> Richard
> 

-- 
regards,
-grygorii