linux-kernel - Re: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Jul 2017 10:11:48 +0530
From:   Arvind Yadav <arvind.yadav.cs@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Sangbeom Kim <sbkim73@...sung.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of
 s3c24xx

Hi,


On Thursday 27 July 2017 10:43 PM, Krzysztof Kozlowski wrote:
> The s3c_i2sv2_probe() only enabled iis clock.  Missing prepare isn't
> probably fatal, because for SoC clocks this is usually no-op, but for
> correctness this clock should be prepared.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
>
> ---
>
> Changes since v1:
> 1. New patch
> ---
>   sound/soc/samsung/s3c-i2s-v2.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/samsung/s3c-i2s-v2.c b/sound/soc/samsung/s3c-i2s-v2.c
> index 9b28046eea8e..3894bda06ebb 100644
> --- a/sound/soc/samsung/s3c-i2s-v2.c
> +++ b/sound/soc/samsung/s3c-i2s-v2.c
> @@ -637,7 +637,7 @@ int s3c_i2sv2_probe(struct snd_soc_dai *dai,
>   		return -ENOENT;
>   	}
>   
> -	clk_enable(i2s->iis_pclk);
> +	clk_prepare_enable(i2s->iis_pclk);
Please, handle are return value of clk_prepare_enble.
>   
>   	/* Mark ourselves as in TXRX mode so we can run through our cleanup
>   	 * process without warnings. */
~arvind