linux-kernel - Re: [PATCH V1 03/12] spmi: pmic-arb: clean up pmic_arb_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60e3f73bc6661166af32eca4a8bd0743@codeaurora.org>
Date:   Fri, 28 Jul 2017 11:03:32 +0530
From:   kgunda@...eaurora.org
To:     Stephen Boyd <sboyd@...eaurora.org>
Cc:     gregkh@...uxfoundation.org,
        Abhijeet Dharmapurikar <adharmap@...eaurora.org>,
        David Collins <collinsd@...eaurora.org>,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-arm-msm-owner@...r.kernel.org
Subject: Re: [PATCH V1 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid
 function

On 2017-07-28 06:48, Stephen Boyd wrote:
> On 07/20, Kiran Gunda wrote:
>> Clean up the pmic_arb_find_apid() by using the local
>> variables to improve the code readability.
>> 
>> Signed-off-by: Kiran Gunda <kgunda@...eaurora.org>
>> ---
> 
> Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>
> 
> One nit below:
> 
>>  			break;
>> 
>>  		regval = readl_relaxed(pmic_arb->cnfg +
>> -				      SPMI_OWNERSHIP_TABLE_REG(apid));
>> -		pmic_arb->apid_data[apid].owner =
>> -					SPMI_OWNERSHIP_PERIPH2OWNER(regval);
>> +					SPMI_OWNERSHIP_TABLE_REG(apid));
> 
> This should be 7 spaces and not a tab? Originally looks like it
> was 6 spaces
Will fix it and send the next patch.