linux-kernel - Re: [PATCH 2/3] staging: ccree: Convert to devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170728084000.vrcr7ql6z72dzo4p@mwanda>
Date:   Fri, 28 Jul 2017 11:40:00 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Suniel Mahesh <sunil.m@...hveda.org>
Cc:     Gilad Ben-Yossef <gilad@...yossef.com>, devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        driverdev-devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        Ofir Drang <ofir.drang@....com>
Subject: Re: [PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for
 map, unmap

On Fri, Jul 28, 2017 at 09:59:41AM +0530, Suniel Mahesh wrote:
> On Friday 28 July 2017 01:18 AM, Dan Carpenter wrote:
> > On Thu, Jul 27, 2017 at 05:27:33PM +0300, Gilad Ben-Yossef wrote:
> >> +	new_drvdata->cc_base = devm_ioremap_resource(&plat_dev->dev,
> >> +						     req_mem_cc_regs);
> >> +	if (IS_ERR(new_drvdata->cc_base)) {
> >> +		rc = PTR_ERR(new_drvdata->cc_base);
> >>  		goto init_cc_res_err;
> >                 ^^^^^^^^^^^^^^^^^^^^
> > (This code was in the original and not introduced by the patch.)
> 
> Hi Dan, the above lines of code were not in the original except 
> "goto init_cc_res_err;" which was doing the error handling at different
> places.
> 

Yes, yes.  I wasn't commenting on the patch just the existing code.

The patch is fine.

regards,
dan carpenter