linux-kernel - [PATCH] drivers:staging:wlan-ng Correct multiple line dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1501236207-27677-1-git-send-email-jananis37@gmail.com>
Date:   Fri, 28 Jul 2017 15:33:27 +0530
From:   janani-sankarababu <jananis37@...il.com>
To:     gregkh@...uxfoundation.org
Cc:     sergio.paracuellos@...il.com, davem@...emloft.net,
        adrien.descamps@...il.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org,
        janani-sankarababu <jananis37@...il.com>
Subject: [PATCH] drivers:staging:wlan-ng Correct multiple line dereference

This patch fixes multiple line dereference Warning reported by checkpath script. This has been made to simplify the code and make it more readable.

Signed-off-by: Janani S <jananis37@...il.com>
---
 drivers/staging/wlan-ng/hfa384x_usb.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index ee5fa86..2fc5f3e 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -1345,15 +1345,13 @@ static int hfa384x_usbctlx_complete_sync(struct hfa384x *hw,
 		kfree(ctlx);
 	} else if (mode == DOWAIT) {
 		struct usbctlx_cmd_completor completor;
+		struct usbctlx_completor *cmplt;
+
+		cmplt = init_cmd_completor(&completor, &ctlx->inbuf.cmdresp,
+					   &cmd->result);

		result =
-		    hfa384x_usbctlx_complete_sync(hw, ctlx,
-						  init_cmd_completor(&completor,
-								     &ctlx->
-								     inbuf.
-								     cmdresp,
-								     &cmd->
-								     result));
+		    hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);
 	}

done:
--
1.9.1