linux-kernel - Re: [PATCH] drivers:staging:wlan-ng Correct multiple line dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Jul 2017 03:34:24 -0700
From:   Joe Perches <joe@...ches.com>
To:     janani-sankarababu <jananis37@...il.com>,
        gregkh@...uxfoundation.org
Cc:     sergio.paracuellos@...il.com, davem@...emloft.net,
        adrien.descamps@...il.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers:staging:wlan-ng Correct multiple line
 dereference

On Fri, 2017-07-28 at 15:33 +0530, janani-sankarababu wrote:
> This patch fixes multiple line dereference Warning reported by checkpath script. This has been made to simplify the code and make it more readable.

Please wrap your commit messages to 75 characters per line.

And run your suggested patches though checkpatch too.

> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
[]
> @@ -1345,15 +1345,13 @@ static int hfa384x_usbctlx_complete_sync(struct hfa384x *hw,
>  		kfree(ctlx);
>  	} else if (mode == DOWAIT) {
>  		struct usbctlx_cmd_completor completor;
> +		struct usbctlx_completor *cmplt;
> +
> +		cmplt = init_cmd_completor(&completor, &ctlx->inbuf.cmdresp,
> +					   &cmd->result);
> 
> 		result =
> -		    hfa384x_usbctlx_complete_sync(hw, ctlx,
> -						  init_cmd_completor(&completor,
> -								     &ctlx->
> -								     inbuf.
> -								     cmdresp,
> -								     &cmd->
> -								     result));
> +		    hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);

This should now be a single line

		result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);