linux-kernel - Re: [RESEND PATCH] ARM: dts: stm32: Add DMA support for STM32F746 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <03a5b6bc-4e33-741c-e065-6f32e2710eee@st.com>
Date:   Fri, 28 Jul 2017 14:29:06 +0200
From:   Alexandre Torgue <alexandre.torgue@...com>
To:     Pierre-Yves MORDRET <pierre-yves.mordret@...com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>
CC:     <devicetree@...r.kernel.or>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        Vladimir Murzin <vladimir.murzin@....com>
Subject: Re: [RESEND PATCH] ARM: dts: stm32: Add DMA support for STM32F746 SoC

Hi Pierre-Yves,

On 07/11/2017 08:54 AM, Pierre-Yves MORDRET wrote:
> This patch adds DMA support for STM32F746 SoC.
> 
> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@...com>
> ---
>   arch/arm/boot/dts/stm32f746.dtsi | 31 +++++++++++++++++++++++++++++++
>   1 file changed, 31 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi
> index c2765ce..bfffea4 100644
> --- a/arch/arm/boot/dts/stm32f746.dtsi
> +++ b/arch/arm/boot/dts/stm32f746.dtsi
> @@ -344,6 +344,37 @@
>   			assigned-clocks = <&rcc 1 CLK_HSE_RTC>;
>   			assigned-clock-rates = <1000000>;
>   		};
> +
> +		dma1: dma@...26000 {
> +			compatible = "st,stm32-dma";
> +			reg = <0x40026000 0x400>;
> +			interrupts = <11>,
> +				     <12>,
> +				     <13>,
> +				     <14>,
> +				     <15>,
> +				     <16>,
> +				     <17>,
> +				     <47>;
> +			clocks = <&rcc 0 21>;
> +			#dma-cells = <4>;
> +		};
> +
> +		dma2: dma@...26400 {
> +			compatible = "st,stm32-dma";
> +			reg = <0x40026400 0x400>;
> +			interrupts = <56>,
> +				     <57>,
> +				     <58>,
> +				     <59>,
> +				     <60>,
> +				     <68>,
> +				     <69>,
> +				     <70>;
> +			clocks = <&rcc 0 22>;
> +			#dma-cells = <4>;
> +			st,mem2mem;
> +		};
>   	};
>   };
>   
> 
Applied on stm32-dt-for-v4.14 branch.

However, I prefer to keep DMA nodes disabled.
Indeed on cortex-M7, dma allocations have to be done in a 
"strongly-ordered" area. So If you want to use DMA you need to create in 
your device tree a "reserved memory" area like that:

+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		linux,dma {
+			compatible = "shared-dma-pool";
+			linux,dma-default;
+			no-map;
+			reg = <0xd1c00000 0x400000>;
+		};
+	};

In the same time, you have to configure in the same way the cortex-m7 
MPU in your bootloader.

FYI, patches are under review to configure MPU directly in the kernel 
(bootloader will not longer have to configure it). It seems also that 
discussions are ongoing about the way to declare "linux,dma" area in 
devicetree.
As soon all discussions will close and MPU patches applied, we will be 
able to enable DMA.

Regards
Alex