linux-kernel - [PATCH] fuse: convert to errseq_t based error tracking for fsync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 28 Jul 2017 08:32:45 -0400
From:   Jeff Layton <jlayton@...nel.org>
To:     Miklos Szeredi <miklos@...redi.hu>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] fuse: convert to errseq_t based error tracking for fsync

From: Jeff Layton <jlayton@...hat.com>

Change to file_write_and_wait_range and
file_check_and_advance_wb_err.

Signed-off-by: Jeff Layton <jlayton@...hat.com>
---
 fs/fuse/file.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

This patch is untested, mostly because I have no idea how to test it.
Based on my experience with other filesystems though, this should make
FUSE do the right thing when reporting writeback errors.

xfstest generic/441 could work with a block-based FUSE fs driver, or
we maybe we could roll some sort of specialized FUSE fault injector
dummy filesystem?

Miklos, do you have any thoughts on ways to test this?

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 3ee4fdc3da9e..e2ffc499d106 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -457,7 +457,7 @@ int fuse_fsync_common(struct file *file, loff_t start, loff_t end,
 	 * wait for all outstanding writes, before sending the FSYNC
 	 * request.
 	 */
-	err = filemap_write_and_wait_range(inode->i_mapping, start, end);
+	err = file_write_and_wait_range(file, start, end);
 	if (err)
 		goto out;
 
@@ -465,10 +465,10 @@ int fuse_fsync_common(struct file *file, loff_t start, loff_t end,
 
 	/*
 	 * Due to implementation of fuse writeback
-	 * filemap_write_and_wait_range() does not catch errors.
+	 * file_write_and_wait_range() does not catch errors.
 	 * We have to do this directly after fuse_sync_writes()
 	 */
-	err = filemap_check_errors(file->f_mapping);
+	err = file_check_and_advance_wb_err(file);
 	if (err)
 		goto out;
 
-- 
2.13.3