linux-kernel - Re: [PATCH v1 3/6] ASoC: codecs: msm8916-wcd-analog: move codec reset to probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <064a5aa7-0a87-7e7b-f263-c24cf66f459a@linaro.org>
Date:   Fri, 28 Jul 2017 15:06:43 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Banajit Goswami <bgoswami@...eaurora.org>,
        alsa-devel@...a-project.org, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Patrick Lai <plai@...eaurora.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/6] ASoC: codecs: msm8916-wcd-analog: move codec reset
 to probe



On 28/07/17 14:40, Mark Brown wrote:
> On Wed, Jul 26, 2017 at 02:35:09AM +0200, srinivas.kandagatla@...aro.org wrote:
>> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>>
>> This patch move the codec reset code from dai ops to codec probe, so
>> that the codec is not held in reset when headset detection block is
>> still active.
> 
> This means that the CODEC will no longer be held in reset (which
> presumably has a power benefit or something) even if jack detection
> isn't in use.  What most devices do is have things like this be
> controlled via the bias level or other power management functions and
> then have jack detection hold the CODEC out of the lowest power states
> when it's active.

This chip has two power sources for MBHC logic, one from mic bias which 
is used when we have active audio usecase, and other from internal 
current source which is for low-power state when no audio use case is 
active.

By default with the existing code uses internal current source which 
puts chip in low power state.


>