lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 28 Jul 2017 15:14:00 +0100
From:   Ian Abbott <abbotti@....co.uk>
To:     Christopher Mårtensson <cribalik@...il.com>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        gregkh@...uxfoundation.org, hsweeten@...ionengravers.com,
        olsonse@...ch.edu
Subject: Re: [PATCH] staging: comedi: ni_mio_common.c: fix coding style issue

On 23/07/17 13:14, Christopher Mårtensson wrote:
>  From 3e90ab52ad9b437d7c09cc667161cdb855c0cc7b Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Christopher=20M=C3=A5rtensson?= <cribalik@...il.com>
> Date: Sun, 23 Jul 2017 13:05:09 +0200
> Subject: [PATCH] staging: comedi: ni_mio_common.c: fix coding style issue
> 
> "checkpatch.pl -f ..." gave
> ERROR: open brace '{' following function definitions go on the next line
> 
> Signed-off-by: Christopher Mårtensson <cribalik@...il.com>
> ---
>   drivers/staging/comedi/drivers/ni_mio_common.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
> index 2f7bfc1..398347f 100644
> --- a/drivers/staging/comedi/drivers/ni_mio_common.c
> +++ b/drivers/staging/comedi/drivers/ni_mio_common.c
> @@ -1962,7 +1962,8 @@ static unsigned int ni_timer_to_ns(const struct comedi_device *dev, int timer)
>   static void ni_cmd_set_mite_transfer(struct mite_ring *ring,
>   				     struct comedi_subdevice *sdev,
>   				     const struct comedi_cmd *cmd,
> -				     unsigned int max_count) {
> +				     unsigned int max_count)
> +{
>   #ifdef PCIDMA
>   	unsigned int nbytes = max_count;
>   
> 

Thanks for the fix.

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ