linux-kernel - Re: [RESEND PATCH] soc: ti: ti_sci_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Jul 2017 11:35:44 -0500
From:   Dave Gerlach <d-gerlach@...com>
To:     Santosh Shilimkar <santosh.shilimkar@...cle.com>
CC:     Vignesh R <vigneshr@...com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH] soc: ti: ti_sci_pm_domains: Populate name for
 genpd

Hi,
On 07/28/2017 11:33 AM, Dave Gerlach wrote:
> Commit b6a1d093f96b ("PM / Domains: Extend generic power domain
> debugfs") now creates a debugfs directory for each genpd based on the
> name of the genpd. Currently no name is given to the genpd created by
> ti_sci_pm_domains driver so because of this we see a NULL pointer
> dereferences when it is accessed on boot when the debugfs entry creation
> is attempted.
> 
> Give the genpd a name before registering it to avoid this.
> 
> Fixes: 52835d59fc6c ("soc: ti: Add ti_sci_pm_domains driver")
> Signed-off-by: Dave Gerlach <d-gerlach@...com>
> ---

Sorry for the noise, last patch had wrong email for Santosh and this one
corrects it. keystone-k2g-evm is crashing on linux-next at boot due to patch
mentioned in the change log, this patch fixes the ti_sci_pm_domains driver to
avoid this. I will also soon send a patch to address what I think is an issue in
the pm domain framework itself to avoid this crash from ever happening.

Regards,
Dave

> 
>  drivers/soc/ti/ti_sci_pm_domains.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/soc/ti/ti_sci_pm_domains.c b/drivers/soc/ti/ti_sci_pm_domains.c
> index b0b283810e72..de31b9389e2e 100644
> --- a/drivers/soc/ti/ti_sci_pm_domains.c
> +++ b/drivers/soc/ti/ti_sci_pm_domains.c
> @@ -176,6 +176,8 @@ static int ti_sci_pm_domain_probe(struct platform_device *pdev)
>  
>  	ti_sci_pd->dev = dev;
>  
> +	ti_sci_pd->pd.name = "ti_sci_pd";
> +
>  	ti_sci_pd->pd.attach_dev = ti_sci_pd_attach_dev;
>  	ti_sci_pd->pd.detach_dev = ti_sci_pd_detach_dev;
>  
>