linux-kernel - Re: [RESEND PATCH 2/6] ipc: mqueue: Replace timespec with timespec64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhTADh8TUpaVjXRNuY+bQ9T-WqGKxmxraaP6NKHdwQ39+Q@mail.gmail.com>
Date:   Fri, 28 Jul 2017 17:06:22 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Deepa Dinamani <deepa.kernel@...il.com>
Cc:     viro@...iv.linux.org.uk, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, arnd@...db.de,
        y2038@...ts.linaro.org, Richard Guy Briggs <rgb@...hat.com>
Subject: Re: [RESEND PATCH 2/6] ipc: mqueue: Replace timespec with timespec64

On Fri, Jul 28, 2017 at 2:52 PM, Deepa Dinamani <deepa.kernel@...il.com> wrote:
> struct timespec is not y2038 safe. Replace
> all uses of timespec by y2038 safe struct timespec64.
>
> Even though timespec is used here to represent timeouts,
> replace these with timespec64 so that it facilitates
> in verification by creating a y2038 safe kernel image
> that is free of timespec.
>
> The syscall interfaces themselves are not changed as part
> of the patch. They will be part of a different series.
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@...il.com>
> Cc: Paul Moore <paul@...l-moore.com>
> Cc: Richard Guy Briggs <rgb@...hat.com>
> ---
>  include/linux/audit.h |  6 +++---
>  ipc/mqueue.c          | 28 ++++++++++++++--------------
>  kernel/audit.h        |  2 +-
>  kernel/auditsc.c      | 12 ++++++------
>  4 files changed, 24 insertions(+), 24 deletions(-)


> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index 3260ba2312a9..d0870f8e3656 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -2083,15 +2083,15 @@ void __audit_mq_open(int oflag, umode_t mode, struct mq_attr *attr)
>   *
>   */
>  void __audit_mq_sendrecv(mqd_t mqdes, size_t msg_len, unsigned int msg_prio,
> -                       const struct timespec *abs_timeout)
> +                       const struct timespec64 *abs_timeout)
>  {
>         struct audit_context *context = current->audit_context;
> -       struct timespec *p = &context->mq_sendrecv.abs_timeout;
> +       struct timespec64 *p = &context->mq_sendrecv.abs_timeout;
>
>         if (abs_timeout)
> -               memcpy(p, abs_timeout, sizeof(struct timespec));
> +               memcpy(p, abs_timeout, sizeof(struct timespec64));

Since you're changing this line, how about changing it to the following:

  memcpy(p, abs_timeout, sizeof(*p));

>         else
> -               memset(p, 0, sizeof(struct timespec));
> +               memset(p, 0, sizeof(struct timespec64));

Same here.

-- 
paul moore
www.paul-moore.com