linux-kernel - Re: [PATCH] staging: unisys: visorbus_main: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170728043520.GA27597@kroah.com>
Date:   Thu, 27 Jul 2017 21:35:20 -0700
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Amitoj Kaur Chawla <amitoj1606@...il.com>
Cc:     david.kershner@...sys.com, sparmaintainer@...sys.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: unisys: visorbus_main: constify attribute_group
 structures

On Tue, Jul 25, 2017 at 06:45:52PM -0400, Amitoj Kaur Chawla wrote:
> Functions working with attribute_groups provided by <linux/device.h>
> work with const attribute_group. These attribute_group structures do not
> change at runtime so mark them as const.
> 
> File size before:
>  text     data     bss     dec     hex filename
>  14216    7304     832   22352    5750
> drivers/staging/unisys/visorbus/visorbus_main.o
> 
> File size after:
>  text     data     bss     dec     hex filename
>  14408    7112     832   22352    5750
> drivers/staging/unisys/visorbus/visorbus_main.o
> 
> This change was made with the help of Coccinelle.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>
> ---
>  drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
> index 1c785dd..bba10dc 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -249,7 +249,7 @@ static struct attribute *channel_attrs[] = {
>  		NULL
>  };
>  
> -static struct attribute_group channel_attr_grp = {
> +static const struct attribute_group channel_attr_grp = {
>  		.name = "channel",
>  		.attrs = channel_attrs,
>  };
> @@ -340,7 +340,7 @@ static struct attribute *dev_attrs[] = {
>  		NULL
>  };
>  
> -static struct attribute_group dev_attr_grp = {
> +static const struct attribute_group dev_attr_grp = {
>  		.attrs = dev_attrs,
>  };
>  

Does not apply to my tree :(

sorry,

greg k-h