linux-kernel - Re: [PATCH v5 1/2] platform: Add driver for RAVE Supervisory Processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 29 Jul 2017 21:23:09 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Andrey Smirnov <andrew.smirnov@...il.com>
Cc:     kbuild-all@...org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andrey Smirnov <andrew.smirnov@...il.com>,
        linux-kernel@...r.kernel.org, cphealy@...il.com,
        Lucas Stach <l.stach@...gutronix.de>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH v5 1/2] platform: Add driver for RAVE Supervisory
 Processor

Hi Andrey,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.13-rc2 next-20170728]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Andrey-Smirnov/ZII-RAVE-platform-driver/20170729-210238
config: blackfin-allyesconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 6.2.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=blackfin 

All errors (new ones prefixed by >>):

   drivers/platform/rave/rave-sp.c: In function 'csum_ccitt':
   drivers/platform/rave/rave-sp.c:458:25: error: implicit declaration of function 'crc_ccitt_false' [-Werror=implicit-function-declaration]
     const u16 calculated = crc_ccitt_false(0xffff, buf, size);
                            ^~~~~~~~~~~~~~~
   drivers/platform/rave/rave-sp.c: In function 'rave_sp_write':
>> drivers/platform/rave/rave-sp.c:495:11: error: 'ENOME' undeclared (first use in this function)
      return -ENOME;
              ^~~~~
   drivers/platform/rave/rave-sp.c:495:11: note: each undeclared identifier is reported only once for each function it appears in
   cc1: some warnings being treated as errors

vim +/ENOME +495 drivers/platform/rave/rave-sp.c

   455	
   456	static void csum_ccitt(const u8 *buf, size_t size, u8 *crc)
   457	{
 > 458		const u16 calculated = crc_ccitt_false(0xffff, buf, size);
   459	
   460		/*
   461		 * While the rest of the wire protocol is little-endian,
   462		 * CCITT-16 CRC in RDU2 device is sent out in big-endian order.
   463		 */
   464		put_unaligned_be16(calculated, crc);
   465	}
   466	
   467	static void *stuff(unsigned char *dest, const unsigned char *src, size_t n)
   468	{
   469		while (n--) {
   470			const unsigned char byte = *src++;
   471	
   472			switch (byte) {
   473			case RAVE_SP_STX:
   474			case RAVE_SP_ETX:
   475			case RAVE_SP_DLE:
   476				*dest++ = RAVE_SP_DLE;
   477				/* FALLTHROUGH */
   478			default:
   479				*dest++ = byte;
   480			}
   481		}
   482	
   483		return dest;
   484	}
   485	
   486	static int rave_sp_write(struct rave_sp *sp, const u8 *data, u8 data_size)
   487	{
   488		const size_t checksum_length = sp->variant->checksum->length;
   489		unsigned char frame[RAVE_SP_TX_BUFFER_SIZE];
   490		unsigned char crc[RAVE_SP_CHECKSUM_SIZE];
   491		unsigned char *dest = frame;
   492		size_t length;
   493	
   494		if (WARN_ON(checksum_length > sizeof(crc)))
 > 495			return -ENOME;
   496	
   497		if (WARN_ON(data_size > sizeof(frame)))
   498			return -ENOMEM;
   499	
   500		sp->variant->checksum->subroutine(data, data_size, crc);
   501	
   502		*dest++ = RAVE_SP_STX;
   503		dest = stuff(dest, data, data_size);
   504		dest = stuff(dest, crc, checksum_length);
   505		*dest++ = RAVE_SP_ETX;
   506	
   507		length = dest - frame;
   508	
   509		print_hex_dump(KERN_DEBUG, "rave-sp tx: ", DUMP_PREFIX_NONE,
   510			       16, 1, frame, length, false);
   511	
   512		return serdev_device_write(sp->serdev, frame, length, HZ);
   513	}
   514	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (45654 bytes)