linux-kernel - Re: [PATCH] ti-msgmgr: fix of_irq_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c918dd3c-8112-f330-831e-3bbc51ec525c@cogentembedded.com>
Date:   Sun, 30 Jul 2017 00:12:01 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Jassi Brar <jassisinghbrar@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ti-msgmgr: fix of_irq_get_byname() error check

On 07/30/2017 12:04 AM, Sergei Shtylyov wrote:

> of_irq_get_byname() may  return 0 as well as negative error number on
> failure,  while the driver only checks for the negative values. The driver
> would then call request_irq(0, ...) in ti_msgmgr_queue_startup() and never
> get a valid channel interrupt.
>
> Check for 'qinst->irq <= 0' instead and return -ENXIO from
> ti_msgmgr_queue_setup() and this fail the driver's probe iff

   s/this/thus/, sorry for the typo.

> of_irq_get_byname() returned 0.
>
> Fixes: aace66b170ce ("mailbox: Introduce TI message manager driver")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
[...]

MBR, Sergei