linux-kernel - Re: [PATCH 3/3] rtc: sun6i: Remove unneeded initalization of ret in sun6i_rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170730144128.2lvg6vxohsbmxw63@piout.net>
Date:   Sun, 30 Jul 2017 16:41:28 +0200
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Alexey Klimov <alexey.klimov@....com>
Cc:     linux-rtc@...r.kernel.org, a.zummo@...ertech.it,
        linux-kernel@...r.kernel.org, maxime.ripard@...e-electrons.com,
        wens@...e.org, robh@...nel.org
Subject: Re: [PATCH 3/3] rtc: sun6i: Remove unneeded initalization of ret in
 sun6i_rtc_setalarm()

Hi,

On 12/07/2017 at 11:59:50 +0100, Alexey Klimov wrote:
> Signed-off-by: Alexey Klimov <alexey.klimov@....com>
> ---
>  drivers/rtc/rtc-sun6i.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
> index 77bc4d3..1886b85 100644
> --- a/drivers/rtc/rtc-sun6i.c
> +++ b/drivers/rtc/rtc-sun6i.c
> @@ -362,7 +362,7 @@ static int sun6i_rtc_setalarm(struct device *dev, struct rtc_wkalrm *wkalrm)
>  	unsigned long time_now = 0;
>  	unsigned long time_set = 0;
>  	unsigned long time_gap = 0;
> -	int ret = 0;
> +	int ret;
>  

I don't see any reason that would justify that change.

>  	ret = sun6i_rtc_gettime(dev, &tm_now);
>  	if (ret < 0) {
> -- 
> 1.9.1
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com