linux-kernel - Re: [PATCH] Staging: vc04_services: Fix WARN_ON instead of BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170731084519.s7zy3cvejtvcqbf2@mwanda>
Date:   Mon, 31 Jul 2017 11:45:19 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     janani-sankarababu <jananis37@...il.com>
Cc:     eric@...olt.net, stefan.wahren@...e.com,
        devel@...verdev.osuosl.org, f.fainelli@...il.com,
        sbranden@...adcom.com, gregkh@...uxfoundation.org,
        vicmos89@...il.com, linux-kernel@...r.kernel.org,
        julia.lawall@...6.fr, mzoran@...wfest.net, sreyamittal5@...il.com,
        rjui@...adcom.com, linux-arm-kernel@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org
Subject: Re: [PATCH] Staging: vc04_services: Fix WARN_ON instead of BUG_ON

On Mon, Jul 31, 2017 at 12:44:03PM +0530, janani-sankarababu wrote:
> This patch is to replace the use of BUG_ON macro with WARN_ON
> inorder to prevent the crashing of the kernel.
> 
> Signed-off-by: Janani Sankara Babu <jananis37@...il.com>
> ---
>  drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
> index f484bb0..30bc246 100644
> --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
> +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
> @@ -91,7 +91,7 @@ static int snd_bcm2835_ctl_get(struct snd_kcontrol *kcontrol,
>  	if (mutex_lock_interruptible(&chip->audio_mutex))
                                      ^^^^^^
We dereference chip here.

>  		return -EINTR;
>  
> -	BUG_ON(!chip && !(chip->avail_substreams & AVAIL_SUBSTREAMS_MASK));
> +	WARN_ON(!chip && !(chip->avail_substreams & AVAIL_SUBSTREAMS_MASK));
                ^^^^^
Too late.

regards,
dan carpenter