linux-kernel - Re: [PATCH] ASoC: improve RT5514 dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hh8xt0xwy.wl-tiwai@suse.de>
Date:   Mon, 31 Jul 2017 11:15:57 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Arnd Bergmann" <arnd@...db.de>
Cc:     "Liam Girdwood" <lgirdwood@...il.com>,
        "Mark Brown" <broonie@...nel.org>, <alsa-devel@...a-project.org>,
        "Matthias Brugger" <matthias.bgg@...il.com>,
        "Hsin-yu Chao" <hychao@...gle.com>,
        "Harsha Priya N" <harshapriya.n@...el.com>,
        "Naveen M" <naveen.m@...el.com>,
        "Vinod Koul" <vinod.koul@...el.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-rockchip@...ts.infradead.org>,
        "Ryder Lee" <ryder.lee@...iatek.com>,
        "Charles Keepax" <ckeepax@...nsource.wolfsonmicro.com>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "Sugar Zhang" <sugar.zhang@...k-chips.com>,
        "Xing Zheng" <zhengxing@...k-chips.com>,
        "Heiko Stuebner" <heiko@...ech.de>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: improve RT5514 dependencies

On Mon, 31 Jul 2017 10:30:55 +0200,
Arnd Bergmann wrote:
> 
> With SND_SOC_RT5514_SPI=m and SND_SOC_RT5514=y, we get this link error:
> 
> sound/soc/codecs/rt5514.o: In function `rt5514_dsp_voice_wake_up_put':
> rt5514.c:(.text+0x2068): undefined reference to `rt5514_spi_burst_write'
> rt5514.c:(.text+0x20c8): undefined reference to `rt5514_spi_burst_write'
> 
> This adds another Kconfig symbol to work around the link error, forcing
> the main driver to be a loadable module as well if some other driver
> selects the I2C side to be built-in.
> 
> Fixes: 2a18483a7fb4 ("ASoC: Intel: Add Kabylake machine driver for RT5514, RT5663 and MAX98927")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> This can now lead to a configuration with
> SND_SOC_INTEL_KBL_RT5663_RT5514_MAX98927_MACH=y and SND_SOC_RT5514=m. I
> don't know if that is a problem or not.
> 
> An alternative approach would be to flip the dependency between
> rt5514_spi.ko and rt5514.ko and avoid having the rt5514_spi_burst_write
> symbol exported.

The current usage of 
  #if defined(CONFIG_SND_SOC_RT5514_SPI)
in rt5514_dsp_voice_wake_up_put() is already broken.  We need the fix
in anyway.

IMO, flipping the dependency looks saner to me.  The SPI function call
is a kind of add-on, after all.


thanks,

Takashi