linux-kernel - Re: [PATCH] psci: add CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8580a81-5cca-462c-24c1-30232e19462e@arm.com>
Date:   Mon, 31 Jul 2017 11:19:39 +0100
From:   Kevin Brodsky <kevin.brodsky@....com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Olof Johansson <olof@...om.net>, Tero Kristo <t-kristo@...com>,
        Thierry Reding <treding@...dia.com>,
        Carlo Caione <carlo@...lessm.com>, Nishanth Menon <nm@...com>,
        Jean Delvare <jdelvare@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] psci: add CPU_IDLE dependency

[Apologies for the resending, damn Thunderbird sending HTML...]

On 31/07/17 09:55, Arnd Bergmann wrote:
> I ran into a build error for the psci_checker:
>
> drivers/firmware/psci_checker.o: In function `psci_checker':
> psci_checker.c:(.init.text+0x528): undefined reference to `cpuidle_devices'
>
> As far as I can tell, this is simply a very rare combination of options,
> but the problem has existed since the code was initially added.
> Adding a Kconfig dependency makes it build properly.

Good catch! For some reason I missed this config option when figuring out the 
dependencies... I wonder though, shouldn't cpuidle.h declare cpuidle_devices 
conditionally on CONFIG_CPU_IDLE?

> Fixes: ea8b1c4a6019 ("drivers: psci: PSCI checker module")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Kevin Brodsky <kevin.brodsky@....com>

Cheers,
Kevin

> ---
>   drivers/firmware/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index 6e4ed5a9c6fd..1983e6e0106f 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -10,7 +10,7 @@ config ARM_PSCI_FW
>   
>   config ARM_PSCI_CHECKER
>   	bool "ARM PSCI checker"
> -	depends on ARM_PSCI_FW && HOTPLUG_CPU && !TORTURE_TEST
> +	depends on ARM_PSCI_FW && HOTPLUG_CPU && CPU_IDLE && !TORTURE_TEST
>   	help
>   	  Run the PSCI checker during startup. This checks that hotplug and
>   	  suspend operations work correctly when using PSCI.