linux-kernel - Re: [PATCH 2/5] Fix "ERROR: code indent should use tabs where possible"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bmo06gzk.fsf@concordia.ellerman.id.au>
Date:   Mon, 31 Jul 2017 20:25:03 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     SZ Lin <sz.lin@...a.com>, ashleydlai@...il.com
Cc:     benh@...nel.crashing.org, paulus@...ba.org, peterhuewe@....de,
        tpmdd@...horst.ne, jarkko.sakkinen@...ux.intel.com,
        jgunthorpe@...idianresearch.com, tpmdd-devel@...ts.sourceforge.net,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        SZ Lin <sz.lin@...a.com>
Subject: Re: [PATCH 2/5] Fix "ERROR: code indent should use tabs where possible"

SZ Lin <sz.lin@...a.com> writes:

> ERROR: code indent should use tabs where possible
> +^I^I         "Need to wait for TPM to finish\n");$
>
> Signed-off-by: SZ Lin <sz.lin@...a.com>
> ---
>  drivers/char/tpm/tpm_ibmvtpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index f01d083eced2..23913fc86158 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -127,7 +127,7 @@ static int tpm_ibmvtpm_send(struct tpm_chip *chip, u8 *buf, size_t count)
>  
>  	if (ibmvtpm->tpm_processing_cmd) {
>  		dev_info(ibmvtpm->dev,
> -		         "Need to wait for TPM to finish\n");
> +			"Need to wait for TPM to finish\n");

There's no reason for that to be on a separate line at all. Just make it
a single line dev_info( ... );

cheers