linux-kernel - RE: [PATCH v2] qe: fix compile issue for arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <877eyo6gf2.fsf@concordia.ellerman.id.au>
Date:   Mon, 31 Jul 2017 20:37:21 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Qiang Zhao <qiang.zhao@....com>,
        "oss\@buserror.net" <oss@...error.net>
Cc:     "valentin.longchamp\@keymile.com" <valentin.longchamp@...mile.com>,
        "linuxppc-dev\@lists.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] qe: fix compile issue for arm64

Qiang Zhao <qiang.zhao@....com> writes:

> Fri 7/28/2017 2:14 PM, Michael Ellerman <mpe@...erman.id.au> wrote:
>
>> -----Original Message-----
>> From: Michael Ellerman [mailto:mpe@...erman.id.au]
>> Sent: Friday, July 28, 2017 2:14 PM
>> To: Qiang Zhao <qiang.zhao@....com>; oss@...error.net
>> Cc: valentin.longchamp@...mile.com; linuxppc-dev@...ts.ozlabs.org; linux-
>> kernel@...r.kernel.org; Qiang Zhao <qiang.zhao@....com>
>> Subject: Re: [PATCH v2] qe: fix compile issue for arm64
>> 
>> Zhao Qiang <qiang.zhao@....com> writes:
>> 
>> > Signed-off-by: Zhao Qiang <qiang.zhao@....com>
>> > ---
>> > Changes for v2:
>> > 	- include all Errata QE_General4 in #ifdef
>> >
>> >  drivers/soc/fsl/qe/qe.c | 2 ++
>> >  1 file changed, 2 insertions(+)
>> 
>> AFAICS this driver can only be built on PPC, what am I missing?
>> 
>> config QUICC_ENGINE
>>         bool "Freescale QUICC Engine (QE) Support"
>>         depends on FSL_SOC && PPC32
>> 
>> cheers
>
> I sent another patchset to support it on arm64.

Where? I don't see it.

Shouldn't this patch be part of that series? Otherwise when that series
is merged the build will break on arm64.

cheers