linux-kernel - Re: [PATCH] clk: samsung: exynos5420: The EPLL rate table corrections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <33f53903-9043-29c0-2cb8-e5d6950cc92f@samsung.com>
Date:   Mon, 31 Jul 2017 14:26:24 +0200
From:   Sylwester Nawrocki <s.nawrocki@...sung.com>
To:     mturquette@...libre.com, sboyd@...eaurora.org
Cc:     cw00.choi@...sung.com, krzk@...nel.org,
        linux-samsung-soc@...r.kernel.org, linux-clk@...r.kernel.org,
        b.zolnierkie@...sung.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: samsung: exynos5420: The EPLL rate table
 corrections

On 07/21/2017 01:19 PM, Sylwester Nawrocki wrote:
> This patch fixes values of the EPLL K coefficient and changes
> the EPLL output frequency values to match exactly what is
> possible to achieve with given M, P, S, K coefficients.
> This allows to avoid rounding errors and unexpected frequency
> being set with clk_set_rate(), due to recalc_rate returning
> different values than the PLL rate specified in the
> exynos5420_epll_24mhz_tbl table. E.g. this prevents a case
> where two consecutive clk_set_rate() calls with same argument
> result in different PLL output frequency.
> 
> The PLL output frequencies have been calculated with formula:
> 
> f = fxtal * (M * 2^16  + K) / (P * 2^S) / 2^16
> 
> where fxtal = 24000000.
> 
> Fixes: 9842452acd ("clk: samsung: exynos542x: Add EPLL rate table")
> Signed-off-by: Sylwester Nawrocki<s.nawrocki@...sung.com>

Stephen, Mike,

Could you apply this patch directly for v4.12-rcX?
It fixes code added in v4.12.

-- 
Thanks,
Sylwester