linux-kernel - Re: [PATCH] staging/pi433: Solved some coding style issues in pi433

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7a8d1907227e84cd7acbf39796209fc-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CUtUWl5BQEcLQVtfSDdUXQheWnYEU1Ja-webmailer1@server06.webmailer.webmailer.hosteurope.de>
Date:   Mon, 31 Jul 2017 14:54:37 +0200
From:   "Wolf Entwicklungen" <Marcus.Wolf@...f-Entwicklungen.de>
To:     "RishabhHardas" <rishabheudyptula@...il.com>
Cc:     gregkh@...uxfoundation.org, linux@...f-entwicklungen.de,
        colin.king@...onical.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org,
        "RishabhHardas" <rishabhhardas@...il.com>
Subject: Re: [PATCH] staging/pi433: Solved some coding style issues in
 pi433_if.c

Reviewed-by: Marcus Wolf <Linux@...f-entwicklungen.de>

Thank you Rishabh!

Marcus

Am Mo, 31.07.2017, 12:21 schrieb RishabhHardas:
> From: RishabhHardas <rishabhhardas@...il.com>
>
> Solved a few coding style issues, used BIT macro to set MINORBITS.
>
> Signed-off-by: RishabhHardas <rishabhhardas@...il.com>
> ---
>  drivers/staging/pi433/pi433_if.c | 24 ++++++++++++++----------
>  1 file changed, 14 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index d9328ce..f10ffc3 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -47,18 +47,18 @@
>  #include <linux/kthread.h>
>  #include <linux/wait.h>
>  #include <linux/spi/spi.h>
> +#include <linux/bitops.h>
>  #ifdef CONFIG_COMPAT
> -#include <asm/compat.h>
> +#include <linux/compat.h>
>  #endif
>
>  #include "pi433_if.h"
>  #include "rf69.h"
>
> -
> -#define N_PI433_MINORS			(1U << MINORBITS) /*32*/	/* ... up to 256 */
> -#define MAX_MSG_SIZE			900	/* min: FIFO_SIZE! */
> -#define MSG_FIFO_SIZE			65536   /* 65536 = 2^16  */
> -#define NUM_DIO				2
> +#define N_PI433_MINORS		BIT(MINORBITS) /*32*/ /* ... up to 256 */
> +#define MAX_MSG_SIZE		900	/* min: FIFO_SIZE! */
> +#define MSG_FIFO_SIZE		65536   /* 65536 = 2^16  */
> +#define NUM_DIO			2
>
>  static dev_t pi433_dev;
>  static DEFINE_IDR(pi433_idr);
> @@ -66,10 +66,14 @@
>
>  static struct class *pi433_class; /* mainly for udev to create /dev/pi433 */
>
> -/* tx config is instance specific
> -	so with each open a new tx config struct is needed */
> -/* rx config is device specific
> -	so we have just one rx config, ebedded in device struct */
> +/*
> + * tx config is instance specific
> + * so with each open a new tx config struct is needed
> + */
> +/*
> + * rx config is device specific
> + * so we have just one rx config, ebedded in device struct
> + */
>  struct pi433_device {
>  	/* device handling related values */
>  	dev_t			devt;
> --
> 1.9.1
>
>
>