linux-kernel - Re: [PATCH] mfd: lp87565: Convert to use devm_mfd_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52f7eb7d-80d9-3261-5cff-ff6537715b6b@ti.com>
Date:   Mon, 31 Jul 2017 09:45:59 +0530
From:   Keerthy <j-keerthy@...com>
To:     Axel Lin <axel.lin@...ics.com>, Lee Jones <lee.jones@...aro.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices



On Sunday 30 July 2017 04:28 PM, Axel Lin wrote:
> This fixes missing mfd_remove_devices() call when unload the module.

Reviewed-by: Keerthy <j-keerthy@...com>

> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/mfd/lp87565.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c
> index 340ad0c..32d2a07 100644
> --- a/drivers/mfd/lp87565.c
> +++ b/drivers/mfd/lp87565.c
> @@ -73,10 +73,9 @@ static int lp87565_probe(struct i2c_client *client,
>  
>  	i2c_set_clientdata(client, lp87565);
>  
> -	ret = mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, lp87565_cells,
> -			      ARRAY_SIZE(lp87565_cells), NULL, 0, NULL);
> -
> -	return ret;
> +	return devm_mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO,
> +				    lp87565_cells, ARRAY_SIZE(lp87565_cells),
> +				    NULL, 0, NULL);
>  }
>  
>  static const struct i2c_device_id lp87565_id_table[] = {
>