linux-kernel - Re: [PATCH] input: keyboard: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbv+8_U8Xhdwo2Ry4p+128pe5ChkvwsfGJgqab2Ri2NZQ@mail.gmail.com>
Date:   Mon, 31 Jul 2017 15:42:00 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Linux Input <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] input: keyboard: constify attribute_group structures.

On Wed, Jul 5, 2017 at 12:46 PM, Arvind Yadav <arvind.yadav.cs@...il.com> wrote:

> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
>    text    data     bss     dec     hex filename
>    5693     464       0    6157    180d drivers/input/keyboard/gpio_keys.o
>
> File size After adding 'const':
>    text    data     bss     dec     hex filename
>    5749     400       0    6149    1805 drivers/input/keyboard/gpio_keys.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij