linux-kernel - Re: [PATCH] xen/events: Fix interrupt lost during irq_disable and irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7409e669-89b3-42cc-3bb9-93d99a8aef2b@oracle.com>
Date:   Mon, 31 Jul 2017 09:58:07 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Liu Shuo <shuo.a.liu@...el.com>, linux-kernel@...r.kernel.org
Cc:     Juergen Gross <jgross@...e.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        David Vrabel <david.vrabel@...rix.com>,
        Ingo Molnar <mingo@...nel.org>,
        Anoob Soman <anoob.soman@...rix.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Len Brown <len.brown@...el.com>,
        KarimAllah Ahmed <karahmed@...zon.de>,
        "moderated list:XEN HYPERVISOR INTERFACE" 
        <xen-devel@...ts.xenproject.org>
Subject: Re: [PATCH] xen/events: Fix interrupt lost during irq_disable and
 irq_enable

On 07/29/2017 12:59 PM, Liu Shuo wrote:
> Here is a device has xen-pirq-MSI interrupt. Dom0 might lost interrupt
> during driver irq_disable/irq_enable. Here is the scenario,
>  1. irq_disable -> disable_dynirq -> mask_evtchn(irq channel)
>  2. dev interrupt raised by HW and Xen mark its evtchn as pending
>  3. irq_enable -> startup_pirq -> eoi_pirq ->
>     clear_evtchn(channel of irq) -> clear pending status
>  4. consume_one_event process the irq event without pending bit assert
>     which result in interrupt lost once
>  5. No HW interrupt raising anymore.
>
> Now use enable_dynirq for enable_pirq of xen_pirq_chip to remove
> eoi_pirq when irq_enable.
>
> Signed-off-by: Liu Shuo <shuo.a.liu@...el.com>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>