linux-kernel - Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 31 Jul 2017 22:13:22 +0530
From:   Jassi Brar <jassisinghbrar@...il.com>
To:     Punit Agrawal <punit.agrawal@....com>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Sudeep Holla <sudeep.holla@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot

[CC'ing Rafael J. Wysocki, who picks patches for pcc.c]

On Mon, Jul 31, 2017 at 3:22 PM, Punit Agrawal <punit.agrawal@....com> wrote:
> Punit Agrawal <punit.agrawal@....com> writes:
>
>> When booting on an ACPI enabled system that does not provide the
>> Platform Communications Channel Table (PCCT), the pcc mailbox driver
>> prints -
>>
>> [    0.484261] PCCT header not found.
>>
>> during probe before returning -ENODEV.
>>
>> This message clutters the bootlog and doesn't provide any useful
>> information. Drop this message.
>>
>> Signed-off-by: Punit Agrawal <punit.agrawal@....com>
>> Cc: Jassi Brar <jassisinghbrar@...il.com>
>> ---
>>  drivers/mailbox/pcc.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
>> index ac91fd0d62c6..3d83cdc11ab5 100644
>> --- a/drivers/mailbox/pcc.c
>> +++ b/drivers/mailbox/pcc.c
>> @@ -457,10 +457,8 @@ static int __init acpi_pcc_probe(void)
>>       /* Search for PCCT */
>>       status = acpi_get_table(ACPI_SIG_PCCT, 0, &pcct_tbl);
>>
>> -     if (ACPI_FAILURE(status) || !pcct_tbl) {
>> -             pr_warn("PCCT header not found.\n");
>> +     if (ACPI_FAILURE(status) || !pcct_tbl)
>>               return -ENODEV;
>> -     }
>>
>>       count = acpi_table_parse_entries(ACPI_SIG_PCCT,
>>                       sizeof(struct acpi_table_pcct),
>
> Ping! Any comments/concerns with dropping the message?
>
> Thanks.