linux-kernel - Re: [net-next PATCH] IB/hns: include linux/interrupt.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1501526645.2725.0.camel@redhat.com>
Date:   Mon, 31 Jul 2017 14:44:05 -0400
From:   Doug Ledford <dledford@...hat.com>
To:     Arnd Bergmann <arnd@...db.de>,
        "David S . Miller" <davem@...emloft.net>,
        Lijun Ou <oulijun@...wei.com>,
        "Wei Hu(Xavier)" <xavier.huwei@...wei.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>
Cc:     Florian Westphal <fw@...len.de>, Salil <salil.mehta@...wei.com>,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [net-next PATCH] IB/hns: include linux/interrupt.h

On Fri, 2017-07-28 at 15:35 +0200, Arnd Bergmann wrote:
> I ran into this build error on linux-next:
> 
> drivers/infiniband/hw/hns/hns_roce_eq.c:477:8: error: unknown type
> name 'irqreturn_t'
>  static irqreturn_t hns_roce_msi_x_interrupt(int irq, void *eq_ptr)
>         ^~~~~~~~~~~
> drivers/infiniband/hw/hns/hns_roce_eq.c: In function
> 'hns_roce_msi_x_interrupt':
> drivers/infiniband/hw/hns/hns_roce_eq.c:485:9: error: implicit
> declaration of function 'IRQ_RETVAL'; did you mean 'BPF_RVAL'? [-
> Werror=implicit-function-declaration]
>   return IRQ_RETVAL(int_work);
> 
> I have bisected this to a seemingly unrelated change that happened
> to remove some indirect header inclusions. Simply including the
> required header explicitly fixes the build failure.
> 
> Fixes: 09c7570480f7 ("xfrm: remove flow cache")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 

Thanks, applied.

-- 
Doug Ledford <dledford@...hat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD