linux-kernel - Re: [PATCH v5] vfat: Deduplicate hex2bin()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1501529949.29303.314.camel@linux.intel.com>
Date:   Mon, 31 Jul 2017 22:39:09 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:     linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v5] vfat: Deduplicate hex2bin()

On Tue, 2017-08-01 at 03:40 +0900, OGAWA Hirofumi wrote:
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:
> 
> > We may use hex2bin() instead of custom approach.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> 
> 

> > +				fill = hex2bin(hc, ip + 1, 2);
> > +				if (fill)
> > +					return fill;
> 
> This should not use random errno (in this case, it is -1 (EPERM)).

You perhaps missed the side note I put after --- line.
It reflects this change.

> 
> > +				*op++ = hc[1];
> > +				*op++ = hc[0];
> 
> Maybe, originally endian bug?

No problem reported. And as you noticed quite ago it is __be16
originally as it goes hi-lo.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy