linux-kernel - Re: security/apparmor/label.c:1498]: (style) Redundant condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <16fc1e64-600e-d1a8-fb59-5910cd3ab92e@canonical.com>
Date:   Mon, 31 Jul 2017 13:11:37 -0700
From:   John Johansen <john.johansen@...onical.com>
To:     David Binderman <dcb314@...mail.com>,
        "james.l.morris@...cle.com" <james.l.morris@...cle.com>,
        "serge@...lyn.com" <serge@...lyn.com>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: security/apparmor/label.c:1498]: (style) Redundant condition

On 07/17/2017 12:34 AM, David Binderman wrote:
> Hello there,
> 
> 
> security/apparmor/label.c:1498]: (style) Redundant condition: prev_ns. '!prev_ns || (prev_ns && *prev_ns!=profile->ns)' is equivalent to '!prev_ns || *prev_ns!=profile->ns'
> 
> Source code is
> 
>     if (view != profile->ns &&
>         (!prev_ns || (prev_ns && *prev_ns != profile->ns))) {
> 

yep, I will add the fix to the next pull request