linux-kernel - Re: [PATCH] fbcon: Use background color for margins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170731211123.trcyj7clxkmkf6df@angband.pl>
Date:   Mon, 31 Jul 2017 23:11:23 +0200
From:   Adam Borowski <kilobyte@...band.pl>
To:     David Lechner <david@...hnology.com>
Cc:     Pavel Machek <pavel@....cz>, linux-fbdev@...r.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fbcon: Use background color for margins

On Mon, Jul 31, 2017 at 12:25:28PM -0500, David Lechner wrote:
> On 07/30/2017 04:51 PM, Pavel Machek wrote:
> > > > > Screens that don't have a black border around the active area will have
> > > > > ugly black bars for the margin when the text background color is not black.
> > > > > This is especially noticeable on an LCD screen (not the backlit kind) when
> > > > > the terminal colors are inverted.

Also when you have multiple monitors of different resolutions (VT does
mirror them which is quite pointless, but hey, VT is meant for rescue tasks
so for fancy features you'd better use X).

I see this on nouveau which your patch doesn't handle, but we can extend it
to nouveau later.

> Ah. I see what you mean now. The margin will be whatever is set for the
> vc_video_erase_char in the kernel, which can be changed by userspace. I
> tried midnight commander and sure enough, I still have the black margins
> when I invert the screen (`setterm -inverse on`). Interestingly, after
> allowing the console to blank after a timeout, the console was blanked with
> white, then after pressing a key to unblank, the margins were also white.

"setterm -inverse on" looks ugly.

I've just added reverse to my vtgamma (https://github.com/kilobyte/vtgamma),
it uses a different method (setting the palette instead of \e[?5h) which on
VT looks a lot nicer.


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀ What Would Jesus Do, MUD/MMORPG edition:
⣾⠁⢰⠒⠀⣿⡁ • multiplay with an admin char to benefit your mortal
⢿⡄⠘⠷⠚⠋⠀ • abuse item cloning bugs (the five fishes + two breads affair)
⠈⠳⣄⠀⠀⠀⠀ • use glitches to walk on water