linux-kernel - Re: [PATCH] crypto: ccp - select CONFIG_CRYPTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <670c80c6-9dc8-881c-51b5-618df900388d@amd.com>
Date:   Tue, 1 Aug 2017 16:17:42 -0500
From:   Gary R Hook <gary.hook@....com>
To:     Arnd Bergmann <arnd@...db.de>,
        "Lendacky, Thomas" <Thomas.Lendacky@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>
Cc:     "Singh, Brijesh" <brijesh.singh@....com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: ccp - select CONFIG_CRYPTO_RSA

On 07/31/2017 04:10 PM, Arnd Bergmann wrote:
> Without the base RSA code, we run into a link error:
>
> ERROR: "rsa_parse_pub_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined!
> ERROR: "rsa_parse_priv_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined!
>
> Like the other drivers implementing RSA in hardware, this
> can be avoided by always enabling the base support when we build
> CCP.
>
> Fixes: ceeec0afd684 ("crypto: ccp - Add support for RSA on the CCP")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/crypto/ccp/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig
> index 15b63fd3d180..6d626606b9c5 100644
> --- a/drivers/crypto/ccp/Kconfig
> +++ b/drivers/crypto/ccp/Kconfig
> @@ -27,6 +27,7 @@ config CRYPTO_DEV_CCP_CRYPTO
>  	select CRYPTO_HASH
>  	select CRYPTO_BLKCIPHER
>  	select CRYPTO_AUTHENC
> +	select CRYPTO_RSA
>  	help
>  	  Support for using the cryptographic API with the AMD Cryptographic
>  	  Coprocessor. This module supports offload of SHA and AES algorithms.
>

Reviewed by: Gary R Hook <gary.hook@....com>