linux-kernel - Re: [PATCH] drivers/net/wan/z85230.c: Use designated initializers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170801.152943.804666349488319640.davem@davemloft.net>
Date:   Tue, 01 Aug 2017 15:29:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     keescook@...omium.org
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] drivers/net/wan/z85230.c: Use designated initializers

From: Kees Cook <keescook@...omium.org>
Date: Sun, 30 Jul 2017 18:31:17 -0700

> In preparation for the randstruct gcc plugin performing randomization of
> structures that are entirely function pointers, use designated initializers
> so the compiler doesn't get angry.
> 
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
> This is a prerequisite for the future randstruct fptr randomization. I'd
> prefer to carry this in my gcc-plugin tree for v4.14 with an Ack from
> someone on net-dev, or if possible, have it applied to v4.13 via net-dev.

Please queue this up into the gcc-plugin tree then:

Acked-by: David S. Miller <davem@...emloft.net>

It isn't a bug fix so I would only have put it into 'net-next' rather
than 'net'.

Thanks.