linux-kernel - Re: lib/test_kmod.c:750: possible garbled statement order ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170801232217.GB18884@wotan.suse.de>
Date:   Wed, 2 Aug 2017 01:22:17 +0200
From:   "Luis R. Rodriguez" <mcgrof@...nel.org>
To:     David Binderman <dcb314@...mail.com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Cc:     "mcgrof@...nel.org" <mcgrof@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: lib/test_kmod.c:750: possible garbled statement order ?

On Mon, Jul 17, 2017 at 07:38:40AM +0000, David Binderman wrote:
> Hello there,
> 
> 
> lib/test_kmod.c:750]: (style) Statements following return, break, continue, goto or throw will never be executed.
> 
>     case TEST_KMOD_FS_TYPE:
>         break;
>         kfree_const(config->test_fs);
>         config->test_driver = NULL;
>         copied = config_copy_test_fs(config, test_str,
>                          strlen(test_str));
>     default:
> 
> Suggest move the break to just before the default label.
> 
> Regards

Thanks David, Dan Carpenter sent a fix for this [0] and I've queued the
patch in.

[0] https://lkml.kernel.org/r/20170707084117.jbi3g364jz75liay@mwanda

  Luis