linux-kernel - [PATCH] usb: xhci: fix call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1708011023340.3044@hadrien>
Date:   Tue, 1 Aug 2017 10:28:07 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Lu Baolu <baolu.lu@...ux.intel.com>
cc:     Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        kbuild-all@...org
Subject: [PATCH] usb: xhci: fix call_kern.cocci warnings

GFP_KERNEL used when a lock is held.  Convert to GFP_ATOMIC to avoid
the possibility of deadlock.

Fixes: 725d53536473 ("usb: xhci: Add DbC support in xHCI driver")
Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

I don't have access to any more of the context than what is shown so I
don't know if this is a real bug.

You may want to see if it is instead possible to pull the call out of the
lock.

tree:   baolu/usb/xhci/dbc/beta-v2
head:   671cb76fa0644a2f72a78fe6aac58c3c3347bc38
commit: 725d53536473cb05cdcf2b81a727ded8875a2a2f [3/4] usb: xhci: Add DbC
support in xHCI driver

 xhci-dbgcap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/usb/host/xhci-dbgcap.c
+++ b/drivers/usb/host/xhci-dbgcap.c
@@ -595,7 +595,7 @@ static int __xhci_dbc_start(struct xhci_
 	if (ret)
 		return ret;

-	ret = xhci_dbc_mem_init(xhci, GFP_KERNEL);
+	ret = xhci_dbc_mem_init(xhci, GFP_ATOMIC);
 	if (ret)
 		return ret;