linux-kernel - Re: [RFC][PATCH]: x86: clarify/fix no-op barriers for text_poke

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1708011109510.30597@cbobk.fhfr.pm>
Date:   Tue, 1 Aug 2017 11:12:46 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Peter Zijlstra <peterz@...radead.org>
cc:     rostedt@...dmis.org, masami.hiramatsu.pt@...achi.com,
        hpa@...ux.intel.com, linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [RFC][PATCH]: x86: clarify/fix no-op barriers for
 text_poke_bp()

On Mon, 31 Jul 2017, Peter Zijlstra wrote:

> So I was looking at text_poke_bp() today and I couldn't make sense of
> the barriers there.
> 
> How's for something like so?

Hm, agreed, the barrier after unsetting in_progress is superfluous, and 
the comments are definitely more understandable this way; I probably 
didn't have one of my best days when writing those back then.

	Acked-by: Jiri Kosina <jkosina@...e.cz>

Thanks,

-- 
Jiri Kosina
SUSE Labs