linux-kernel - Re: [PATCH 1/2 v2] backlight: gpio: Convert to use GPIO descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1756887.aE0tBDJMo9@avalon>
Date:   Tue, 01 Aug 2017 13:29:16 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2 v2] backlight: gpio: Convert to use GPIO descriptor

Hi Linus,

Thank you for the patch.

On Tuesday 01 Aug 2017 10:20:32 Linus Walleij wrote:
> On Tue, May 30, 2017 at 1:48 PM, Linus Walleij <linus.walleij@...aro.org> 
wrote:
> > This driver is predominantly used by device tree systems, all
> > of which can deal with modern GPIO descriptors. The legacy
> > GPIO API is only used by one SH board so make the GPIO
> > descriptor the default way to deal with it.
> > 
> > As an intended side effect we do not need to look around in
> > the device tree for the inversion flag since the GPIO
> > descriptors will intrinsically deal with this.
> > 
> > Acked-by: Daniel Thompson <daniel.thompson@...aro.org>
> > Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> > ---
> > ChangeLog v1->v2:
> > - Assign flags value using the ternary operator.
> 
> This patch seems to have been inadvertedly dropped?
> 
> Can it be applied, along with 2/2?
> 
> Yours,
> Linus Walleij

-- 
Regards,

Laurent Pinchart