lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Aug 2017 14:04:26 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Linus Walleij <linus.walleij@...aro.org> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Masahiro Yamada <yamada.masahiro@...ionext.com>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, Grygorii Strashko <grygorii.strashko@...com>, William Breathitt Gray <vilhelm.gray@...il.com>, Ray Jui <rjui@...adcom.com>, Sören Brinkmann <soren.brinkmann@...inx.com>, David Cohen <david.a.cohen@...ux.intel.com>, Scott Branden <sbranden@...adcom.com>, ACPI Devel Maling List <linux-acpi@...r.kernel.org>, bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>, Florian Fainelli <f.fainelli@...il.com>, Thierry Reding <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, Alexander Shiyan <shc_work@...l.ru>, Michal Simek <michal.simek@...inx.com>, Kevin Hilman <khilman@...nel.org>, "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>, Joel Stanley <joel@....id.au>, Linux-OMAP <linux-omap@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Mika Westerberg <mika.westerberg@...ux.intel.com>, patches@...nsource.cirrus.com, Alban Bedel <albeu@...e.fr>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Santosh Shilimkar <ssantosh@...nel.org>, Thor Thayer <thor.thayer@...ux.intel.com>, Tien Hock Loh <thloh@...era.com> Subject: Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h On Tue, Aug 1, 2017 at 10:53 AM, Linus Walleij <linus.walleij@...aro.org> wrote: > On Mon, Jul 31, 2017 at 4:04 PM, Andy Shevchenko > <andriy.shevchenko@...ux.intel.com> wrote: >> On Mon, 2017-07-31 at 15:48 +0200, Linus Walleij wrote: >>> On Tue, Jul 4, 2017 at 12:06 PM, Andy Shevchenko >>> <andriy.shevchenko@...ux.intel.com> wrote: >>> > If Linus is okay with the following proposal I would rather go with >>> > it, >>> > i.e. logical split the series to >>> > >>> > 1. Fix IRQ related headers inclusion >>> > 2. Fix pinconf-generic.h inclusion >>> > 3. Fix OF headers inclusion (btw, of_gpio.h is not enough there?) >>> >>> That works fine with me, but also one big patch actually, I do not >>> want to make it too much work to refactor obviously incorrect things. >>> >>> As soon as we have rough consensus on this and the build robot >>> are happy I will apply it to GPIO and also pull it into the pinctrl >>> subsystem. >> >> For me priorities like this: >> 1) it works after the patch being applied (no regressions); >> 2) it makes code cleaner at the end; >> 3) it is presented in logically split parts. >> >> So, as long as 1) and 2) are satisfied I can neglect on 3). > > We are in violent agreement :D What I would like to say is that is up to you after all :-) For me looks better to split. -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists