linux-kernel - Re: [PATCH] apparmor: Fix logical error in verify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 31 Jul 2017 17:22:29 -0700
From:   John Johansen <john.johansen@...onical.com>
To:     Christos Gkekas <chris.gekas@...il.com>,
        James Morris <james.l.morris@...cle.com>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] apparmor: Fix logical error in verify_header()

On 07/08/2017 12:50 PM, Christos Gkekas wrote:
> verify_header() is currently checking whether interface version is less
> than 5 *and* greater than 7, which always evaluates to false. Instead it
> should check whether it is less than 5 *or* greater than 7.
> 
> Signed-off-by: Christos Gkekas <chris.gekas@...il.com>

sigh, yes. sorry for the delay this ended up in the wrong bucket.

I've pulled it in for the next pull

Acked-by: John Johansen <john.johansen@...onical.com>


> ---
>  security/apparmor/policy_unpack.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/apparmor/policy_unpack.c b/security/apparmor/policy_unpack.c
> index c600f4d..f273c61 100644
> --- a/security/apparmor/policy_unpack.c
> +++ b/security/apparmor/policy_unpack.c
> @@ -832,7 +832,7 @@ static int verify_header(struct aa_ext *e, int required, const char **ns)
>  	 * if not specified use previous version
>  	 * Mask off everything that is not kernel abi version
>  	 */
> -	if (VERSION_LT(e->version, v5) && VERSION_GT(e->version, v7)) {
> +	if (VERSION_LT(e->version, v5) || VERSION_GT(e->version, v7)) {
>  		audit_iface(NULL, NULL, NULL, "unsupported interface version",
>  			    e, error);
>  		return error;
>