linux-kernel - Re: [PATCH] fs, proc: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170801121519.GH15774@dhcp22.suse.cz>
Date:   Tue, 1 Aug 2017 14:15:20 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Hugh Dickins <hughd@...gle.com>,
        Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs, proc: remove unused variable

On Tue 01-08-17 14:01:20, Arnd Bergmann wrote:
> The last cleanup can go a little further, as shown by this warning:
> 
> fs/proc/task_mmu.c: In function 'show_map_vma':
> fs/proc/task_mmu.c:285:28: error: unused variable 'priv' [-Werror=unused-variable]
> 
> Fixes: 14ccc3193225 ("fs, proc: remove priv argument from is_stack")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks Arnd! Andrew, could you fold this into
fs-proc-remove-priv-argument-from-is_stack.patch please?

> ---
>  fs/proc/task_mmu.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 9782dedeead7..186e907187ab 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -282,7 +282,6 @@ show_map_vma(struct seq_file *m, struct vm_area_struct *vma, int is_pid)
>  {
>  	struct mm_struct *mm = vma->vm_mm;
>  	struct file *file = vma->vm_file;
> -	struct proc_maps_private *priv = m->private;
>  	vm_flags_t flags = vma->vm_flags;
>  	unsigned long ino = 0;
>  	unsigned long long pgoff = 0;
> -- 
> 2.9.0
> 

-- 
Michal Hocko
SUSE Labs