linux-kernel - Re: [PATCH v4 1/5] treewide: Consolidate Apple DMI checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Aug 2017 16:11:14 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Lukas Wunner <lukas@...ner.de>
Cc:     "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, x86@...nel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Matt Fleming <matt@...eblueprint.co.uk>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Andreas Noever <andreas.noever@...il.com>,
        Michael Jamet <michael.jamet@...el.com>,
        Yehezkel Bernat <yehezkel.bernat@...el.com>,
        Ronald Tschalaer <ronald@...ovation.ch>,
        Federico Lorenzi <florenzi@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Leif Liddy <leif.liddy@...il.com>,
        Daniel Roschka <danielroschka@...enitydawn.de>,
        Mark Brown <broonie@...nel.org>, linux-acpi@...r.kernel.org,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lv Zheng <lv.zheng@...el.com>,
        Darren Hart <dvhart@...radead.org>
Subject: Re: [PATCH v4 1/5] treewide: Consolidate Apple DMI checks

On Tue, Aug 01, 2017 at 02:10:41PM +0200, Lukas Wunner wrote:
> We're about to amend ACPI bus scan with DMI checks whether we're running
> on a Mac to support Apple device properties in AML.  The DMI checks are
> performed for every single device, adding overhead for everything x86
> that isn't Apple, which is the majority.  Rafael and Andy therefore
> request to perform the DMI match only once and cache the result.
> 
> Outside of ACPI various other Apple DMI checks exist and it seems
> reasonable to use the cached value there as well.  Rafael, Andy and
> Darren suggest performing the DMI check in arch code and making it
> available with a header in include/linux/platform_data/x86/.
> 
> To this end, add early_platform_quirks() to arch/x86/kernel/quirks.c
> to perform the DMI check and invoke it from setup_arch().  Switch over
> all existing Apple DMI checks, thereby fixing two deficiencies:
> 
> * They are now #defined to false on non-x86 arches and can thus be
>   optimized away if they're located in cross-arch code.
> 
> * Some of them only match "Apple Inc." but not "Apple Computer, Inc.",
>   which is used by BIOSes released between January 2006 (when the first
>   x86 Macs started shipping) and January 2007 (when the company name
>   changed upon introduction of the iPhone).
> 
> Cc: Lv Zheng <lv.zheng@...el.com>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: H. Peter Anvin <hpa@...or.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Matt Fleming <matt@...eblueprint.co.uk>
> Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> Cc: Andreas Noever <andreas.noever@...il.com>
> Cc: Michael Jamet <michael.jamet@...el.com>
> Cc: Yehezkel Bernat <yehezkel.bernat@...el.com>
> Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>

For the thunderbolt bits:

Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>