linux-kernel - [PATCH 3/3] ACPI / APEI: HEST: Don't set hest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue,  1 Aug 2017 14:36:08 +0100
From:   Punit Agrawal <punit.agrawal@....com>
To:     linux-acpi@...r.kernel.org
Cc:     Punit Agrawal <punit.agrawal@....com>, lorenzo.pieralisi@....com,
        sudeep.holla@....com, linux-kernel@...r.kernel.org,
        Borislav Petkov <bp@...e.de>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>
Subject: [PATCH 3/3] ACPI / APEI: HEST: Don't set hest_disable if table not found

During initialisation, the driver sets hest_disable to 1 if the HEST
table is not found. This value is checked during the GHES driver
initialisation and in turn leads to a message such as -

[    3.460067] GHES: HEST is not enabled!

being output in the bootlog. The message appears even on systems that do
not have the HEST table or APEI support.

Update the initialisation to skip setting hest_disable when the HEST
table is not found.

Signed-off-by: Punit Agrawal <punit.agrawal@....com>
Cc: Borislav Petkov <bp@...e.de>
---
 drivers/acpi/apei/hest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
index 456b488eb1df..3aa1b34459b6 100644
--- a/drivers/acpi/apei/hest.c
+++ b/drivers/acpi/apei/hest.c
@@ -233,7 +233,7 @@ void __init acpi_hest_init(void)
 	status = acpi_get_table(ACPI_SIG_HEST, 0,
 				(struct acpi_table_header **)&hest_tab);
 	if (status == AE_NOT_FOUND)
-		goto err;
+		return;
 	else if (ACPI_FAILURE(status)) {
 		const char *msg = acpi_format_exception(status);
 		pr_err(HEST_PFX "Failed to get table, %s\n", msg);
-- 
2.11.0