linux-kernel - Re: [PATCH] video: fbdev: uvesafb: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <2391550.2naV14eqVs@amdc3058>
Date:   Tue, 01 Aug 2017 15:53:28 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     spock@...too.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: uvesafb: constify attribute_group
 structures.

On Wednesday, July 19, 2017 10:46:55 AM Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   15426	   4952	    187	  20565	   5055	drivers/video/fbdev/uvesafb.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>   15490	   4888	    187	  20565	   5055	drivers/video/fbdev/uvesafb.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Patch queued for 4.14, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics