linux-kernel - RE: Issue with commit de3ef1eb1cd - PM / core: Drop run_wake flag from struct dev_pm_info [Was: MEI-related WARN_ON() triggered during resume-from-sleep on v4.13-rc2+]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B749D55CC@hasmsx108.ger.corp.intel.com>
Date:   Tue, 1 Aug 2017 13:58:04 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>,
        "Usyskin, Alexander" <alexander.usyskin@...el.com>
CC:     Dominik Brodowski <linux@...inikbrodowski.net>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>
Subject: RE: Issue with commit de3ef1eb1cd - PM / core: Drop run_wake flag
 from struct dev_pm_info [Was: MEI-related WARN_ON() triggered during
 resume-from-sleep on v4.13-rc2+]

> 
> Hi,
> 
> On Tue, Aug 1, 2017 at 7:25 AM, Usyskin, Alexander
> <alexander.usyskin@...el.com> wrote:
> > Hi
> >
> > We using pci_dev_run_wake that changed in mentioned patch to decide if
> > to replace usual PM callbacks with domain ones.
> > IIRC, the mei device is not remote wakeable on that platform, so we
> > should set domain callbacks.
> > There was a patch in PM framework that squashes runtime suspend with
> > usual suspend for some devices.
> > May it be that now pci_dev_run_wake returns true form mei and we are
> > not setting domain callbacks?
> > In that case we going through PCI device level PM path and may trigger
> that squash.
> > That will explain lack of mei logs on suspend.
> >
> > Dominik, can you try comment out "if (!pci_dev_run_wake(pdev))"
> > at drivers/misc/mei/pci-me.c (around line 223) to set domain callbacks
> > by force to see if this is indeed the case?
> 
> Why exactly do you need the pci_dev_run_wake(pdev) check?

We need to re-review this code now, but as far as I remember.
On some platforms with NFC connected via MEI, there was no PME enabled,  hence we needed to keep in band irq opened for rx to wake us up.
 
Thanks
Tomas