linux-kernel - Re: [PATCH 4.4 07/83] NFC: fix broken device allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1501611355.2047.6.camel@codethink.co.uk>
Date:   Tue, 01 Aug 2017 19:15:55 +0100
From:   Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:     Johan Hovold <johan@...nel.org>,
        Samuel Ortiz <sameo@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 4.4 07/83] NFC: fix broken device allocation

On Tue, 2017-07-25 at 12:18 -0700, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Johan Hovold <johan@...nel.org>
> 
> commit 20777bc57c346b6994f465e0d8261a7fbf213a09 upstream.
[...]
> --- a/net/nfc/core.c
> +++ b/net/nfc/core.c
[...]
> @@ -1077,6 +1089,11 @@ struct nfc_dev *nfc_allocate_device(stru
>  	}
>  
>  	return dev;
> +
> +err_free_dev:
> +	kfree(dev);
> +
> +	return ERR_PTR(rc);
>  }
>  EXPORT_SYMBOL(nfc_allocate_device);
[...]

But the callers expect a null pointer on error, not an error pointer.
This looks broken in mainline too.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.